Skip to content

Comments

2.x#592

Closed
CodingLukas wants to merge 2 commits intoessentials:2.xfrom
CodingLukas:2.x
Closed

2.x#592
CodingLukas wants to merge 2 commits intoessentials:2.xfrom
CodingLukas:2.x

Conversation

@CodingLukas
Copy link
Contributor

No description provided.

iBo3oF added 2 commits November 26, 2013 19:46
Added MoneySetEvent ignite.
@khobbits
Copy link
Member

Why would you want an event firing here?

@CodingLukas
Copy link
Contributor Author

Because it's moneySet method. It would be best place for scoreboards plugin, isn't it? I suppose it's best place, if no, please correct me.

@khobbits
Copy link
Member

This code isn't executed if you have another economy plugin.
It will also be triggered by other plugins that use our eco api.

Is that what you would want?

@CodingLukas
Copy link
Contributor Author

Yes, to optimize Scoreboard plugins it's perfect. I don't like task, which is running every xx ticks.

@khobbits
Copy link
Member

3caf99f

@khobbits khobbits closed this Nov 26, 2013
@khobbits
Copy link
Member

As long as you know it will be triggered by other plugins, not just from Essentials signs/commands.

@chrisgward
Copy link
Member

Wouldn't you want a money changed event, not a set event?

@chrisgward
Copy link
Member

Never mind, I just read the code :>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants